Category Archives: STL

Avoid finding twice the same key in the map (part 2)

Posted on 19-Feb-2015 by christophe

Later, I found the following code:

auto p = map.find(key);
if (p != map.end()) {
    throw std::runtime_error(...);
}
prepare(value);
map[key] = value;

auto p = map.find(key);

if (p != map.end()) {

throw std::runtime_error(...);

}

prepare(value);

map[key] = value;

Posted in C++, C++11, STL | Leave a comment

Posted on 19-Feb-2015 by christophe

This is unfortunate, but I regularly still see the following piece of code:

auto p = map.find(key); // (1)
if (p != map.end()) {
    throw std::runtime_error(...);
}
map[key] = value;      // (2)

auto p = map.find(key); // (1)

if (p != map.end()) {

throw std::runtime_error(...);

}

map[key] = value; // (2)

Posted in C++, C++11, STL | Leave a comment